Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: Remove cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4 job #30534

Merged
merged 1 commit into from
Aug 28, 2023
Merged

CAPI: Remove cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4 job #30534

merged 1 commit into from
Aug 28, 2023
+0 −53

Conversation

adilGhaffarDev
Copy link
Contributor

Removing periodic-cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4 because v1.4 does not even support v1.28

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @adilGhaffarDev!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @adilGhaffarDev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 28, 2023
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@furkatgofurov7
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2023
furkatgofurov7
furkatgofurov7 reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @sbueringer @killianmuldoon @fabriziopandini

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Aug 28, 2023 •
edited
Loading

/retitle CAPI: Remove cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4 job

@k8s-ci-robot k8s-ci-robot changed the title Removed cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4 CAPI: Remove cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4 job Aug 28, 2023
@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79c403f into kubernetes:master Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

@adilGhaffarDev: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-release-1-4-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-4-upgrades.yaml

In response to this:

Removing periodic-cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4 because v1.4 does not even support v1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo Sunnatillo deleted the ci-capi-1.4-fix/adil branch August 29, 2023 06:13
@adilGhaffarDev adilGhaffarDev mentioned this pull request Nov 9, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@davidewatson davidewatson Awaiting requested review from davidewatson

@justinsb justinsb Awaiting requested review from justinsb

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adilGhaffarDev @k8s-ci-robot @chrischdi @furkatgofurov7 @sbueringer